Fix LoRaWAN PHY settings for SX126x driver #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set preamble length to 8 symbols * Set polarity to inverted for received messages
lulf
approved these changes
Nov 21, 2022
bors bot
added a commit
that referenced
this pull request
Nov 21, 2022
1064: Fix LoRaWAN PHY settings for SX126x driver r=lulf a=jbeaurivage While working on #1023 / #1041, I noticed that the `lorawan_device::PhyTxRx` implementation does not conform to the LoRaWAN standard, and therefore devices using this driver could never communicate with a gateway. This PR backports the changes I've made to fix the offending parameters, and I can confirm that the driver now works with LoRaWAN networks. * Set preamble length to 8 symbols * Set polarity to inverted for received messages Co-authored-by: Justin Beaurivage <justin@wearableavionics.com>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2022
1060: feat: embassy-usb-logger and example for rpi pico r=Dirbaio a=lulf * Add embassy-usb-logger which allows logging over USB for any device implementing embassy-usb * Add example using logger for rpi pico 1064: Fix LoRaWAN PHY settings for SX126x driver r=Dirbaio a=jbeaurivage While working on #1023 / #1041, I noticed that the `lorawan_device::PhyTxRx` implementation does not conform to the LoRaWAN standard, and therefore devices using this driver could never communicate with a gateway. This PR backports the changes I've made to fix the offending parameters, and I can confirm that the driver now works with LoRaWAN networks. * Set preamble length to 8 symbols * Set polarity to inverted for received messages Co-authored-by: Ulf Lilleengen <lulf@redhat.com> Co-authored-by: Justin Beaurivage <justin@wearableavionics.com>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1023 / #1041, I noticed that the
lorawan_device::PhyTxRximplementation does not conform to the LoRaWAN standard, and therefore devices using this driver could never communicate with a gateway. This PR backports the changes I've made to fix the offending parameters, and I can confirm that the driver now works with LoRaWAN networks.