-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rollback BUCC revision #1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally intfloat/multilingual-e5-small
is a bit hard to reproduce if not run by our implementation and even if it is, the task prompts might change making it harder to reproduce (we could consider logging this).
# BUCC outputs a dict instead of a Dataset | ||
subsets = list(pair_elements) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we change the dataset instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to change it, but it resulted in a different number of sentence1
and sentence2
, which prevented me from creating a dataset.Dataset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if any changes here address this comment in the linked issue. Could you please take a look at that and the paper to confirm what's missing? (i.e. wrong split used/uploaded, should be a cross-lingual retrieval task)
For now, I've made changes to ensure that BUCC is working. After that, we can investigate how it’s supposed to work and deprecate this |
It's ok to do this in a separate PR. As mentioned here, hope my comment in the issue would give you a head start. |
Checklist
make test
.make lint
.Closing: #1694
Results for
sentence-transformers/LaBSE
, since I can't reproduce results forintfloat/multilingual-e5-small
. Maybe they used forquery:
as prefix here.