Remove the helper wrapper from the helper generator
#20825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
generate-plain-function-helpers
branch
2 times, most recently
from
ff7543d to
15f4abe
Compare
NullVoxPopuli
approved these changes
Jan 13, 2025
Windvis
changed the title
helper wrapper from the helper generator
Plain function helpers have been supported since ember-source 4.5 so we no longer need the wrapping `helper` call.
Windvis
force-pushed
the
generate-plain-function-helpers
branch
from
15f4abe to
eccc9e1
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain function helpers have been supported since ember-source 4.5 so we no longer need the wrapping
helpercall.