Report egui::Window contents as children to accesskit #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5240-accesskit_window_parent |
|
Awesome! Also, once #5166 is done we should be able to simplify the accesskit tests using kittest |
|
That was indeed my idea as well 😄. |
emilk
approved these changes
Oct 29, 2024
emilk
added
accessibility
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Previously, all widgets would be listed in accesskit as children of the toplevel window. With this change, they will be reported as child of the `egui::Window` they are in, Which should increase parseability of the ui for screenreaders and integration tests. Added an accesskit test to check that it is indeed working. Co-authored-by: Wybe Westra <w.westra@kwantcontrols.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all widgets would be listed in accesskit as children of the toplevel window.
With this change, they will be reported as child of the
egui::Windowthey are in, Which should increase parseability of the ui for screenreaders and integration tests.Added an accesskit test to check that it is indeed working.