Use bitfield instead of bools in Response and Sense
#5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polwel
commented
Jan 1, 2025
polwel
changed the title
emilk
changed the title
Response and Sense
|
Preview available at https://egui-pr-preview.github.io/pr/5556-bitflags |
|
Thanks for the review! I will address your comments shortly. I see one CI job is failing, but it does not look like something I touched? I can fix it, but should I? EDIT NVM, I see it's already corrected in master. Will rebase. |
polwel
force-pushed
the
bitflags
branch
2 times, most recently
from
a69fa29 to
507c3e9
Compare
emilk
approved these changes
Jan 6, 2025
| && memory.has_focus(id) | ||
| && (input.key_pressed(Key::Space) || input.key_pressed(Key::Enter)) | ||
| { | ||
| // Space/enter works like a primary click for e.g. selected buttons | ||
| res.fake_primary_click = true; | ||
| res.flags.set(Flags::FAKE_PRIMARY_CLICKED, true); |
There was a problem hiding this comment.
Nit: these could be shorter by using += or |=
Suggested change
| res.flags.set(Flags::FAKE_PRIMARY_CLICKED, true); | |
| res.flags += Flags::FAKE_PRIMARY_CLICKED; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3862.
Factoring the
boolmembers ofResponseinto a bitfield, the size ofResponseis now 96 bytes (down from 104).I gave
Sensethe same treatment, however this has no effects onResponsedue to padding. I've decided not to pursuePointerState, as it is quite large (many members that are sized and aligned to multiples of 8 bytes), so I don't expect any noticeable benefit from making handful ofbools slightly leaner.In any case, the changes to
Senseare already quite a bit more intrusive than those toResponse.The previous implementation overloaded the names of the attributes
clickanddragwith similarly named methods that constructSensewith the corresponding flag set. Now, that the attributes can no longer be accessed directly, I had to introduce methods with new names (senses_click(),senses_drag()andis_focusable()). I don't think this is the cleanest solution: the old methods are essentially redundant now that the named constants likeSense::CLICKexist. I did however not want to needlessly break backwards compatibility.I am happy to revert it (or go further 🙂) if there are concerns.