Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for comboboxes #5574

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add a test for comboboxes #5574

merged 3 commits into from
Jan 7, 2025

Conversation

lucasmerlin
Copy link
Collaborator

  • I have followed the instructions in the PR template

@lucasmerlin lucasmerlin added the tests Unit tests, regression tests, manual tests, … label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Preview available at https://egui-pr-preview.github.io/pr/5574-lucascomboboxtest
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

bircni
bircni approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good - thank you!

@emilk emilk merged commit 7186f72 into master Jan 7, 2025
46 checks passed
@emilk emilk deleted the lucas/combobox_test branch January 7, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bircni bircni bircni approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog tests Unit tests, regression tests, manual tests, …
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmerlin @emilk @bircni