Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for objc2 frameworks v0.3 #5624

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jan 21, 2025

The next version of the objc2 framework crates will have a bunch of default features enabled, see madsmtm/objc2#627, so this PR pre-emptively disables them, so that your compile times down blow up once you upgrade to the next version (which is yet to be released, but will be soon).

  • I have followed the instructions in the PR template

These will have a bunch of default features enabled, so let's
pre-emptively disable them.
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5624-objc2-disable-default-features
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk added eframe Relates to epi and eframe dependencies Pull requests that update a dependency file exclude from changelog labels Jan 22, 2025
@emilk emilk merged commit a04e25a into emilk:master Jan 22, 2025
27 of 28 checks passed
@madsmtm madsmtm deleted the objc2-disable-default-features branch January 22, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe exclude from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants