Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nohash_hasher::IsEnabled for Id #5628

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jan 22, 2025

egui::id::IdSet and egui::id::IdMap were already optimized to not do additional hashing (because the Id already is a hash), but now they are just type aliases for nohash_hasher::IntSet/IntMap.

See https://crates.io/crates/nohash-hasher for more

@emilk emilk changed the title Refactor: use nohash_hasher for IdSet Implement nohash_hasher::IsEnabled for Id Jan 22, 2025
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5628-emilkno-hash-hasher-id-set
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk merged commit 71f7bdc into master Jan 22, 2025
51 checks passed
@emilk emilk deleted the emilk/no-hash-hasher-id-set branch January 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant