-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating external dependencies #26
base: master
Are you sure you want to change the base?
Conversation
Impressive improvements! However, this PR causes problems on my Mac:
The glog benchamrks/examples on the |
[Copy pasting from my reply to the email - GitHub notifications didn't pick that one up] Thanks for writing back. I’ll try to address your concern to the best of my ability. The primary problem I faced with glog v0.3.4 was that it didn’t have a CMakeLists.txt file. It’s not surprising considering the release is almost two years old (will be this March). This makes it difficult to be able to build it with the same commands across platforms (Linux, macOS and Windows). I chose the latest master because it has CMake support to build on all platforms (I tried Linux and Windows; evidently missed macOS). The error you describe is in glog code. I’ll check if it builds independently on my mac. (Just ran the tests): It builds fine (with the warnings though) on my machine (Sierra 10.12.2). To help you further, I need more details from your build environment – for instance the compiler you use (Apple clang? Version?) and any external factors that may have affected the build, like the GFlags namespace option, etc. |
Has this PR been superseded by the merging of #28? Can I close this? |
[happened again with GitHub notification] I believe we can address the concerns you had brought up earlier and merge this one separately. Meanwhile, I can try to keep this fast-forwardable. |
- Add Git submodules for `Glog` (master - require `CMakeLists.txt`) and `Gflags` (v2.2.0). - Collect all glog dependent targets in loguru in `external/test`. - Add `CMakeLists.txt` for building the libraries `glog` and `gflags` and the test projects `glog_bench` and `glog_example`. - Add a CMake script `build_and_run.cmake` (wrapper) for building and running the tests. - Add a `README.md` file explaing the intent and the steps to run the external tests locally.
- glog_bench in Release configuration produces better results on Windows
This PR contains
build_and_run.cmake
(instead of shell), to use on Windows also.This allows running the glog_* tests on all platforms (with CMake). The same can be followed further for the internal tests (loguru_bench and loguru_example).