[tsgen] Support JSPI when emitting TypeScript definitions. #23320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a Promise<T> wrapper around the return type for async embind functions. - Disables JSPI while generating the definitions, since it's not needed. Fixes emscripten-core#23272
sbc100
reviewed
Jan 7, 2025
| # JSPI is not needed to generate the definitions. | ||
| # TODO: when the emsdk node version supports JSPI, it probably makes more sense | ||
| # to enable it in node than disabling the setting here. | ||
| settings.ASYNCIFY = 0 |
There was a problem hiding this comment.
Why not settings.JSPI = 0 here?
There was a problem hiding this comment.
JSPI really is just ASYNCIFY = 2. I guess it's probably more clear if only use the asyncify setting, e.g. if settings.ASYNCIFY == 2:.
sbc100
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23272