Delay processing of --js-library flags. NFC #23332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By delaying the processing of `--js-library` arguments we avoid having jump through hoops and store them alongside their ordinal number for half the time.
kripken
reviewed
Jan 8, 2025
| @@ -1240,7 +1240,7 @@ def phase_linker_setup(options, state): # noqa: C901, PLR0912, PLR0915 | |||
| state.append_link_flag('--no-whole-archive') | |||
| settings.FILESYSTEM = 1 | |||
| settings.SYSCALLS_REQUIRE_FILESYSTEM = 0 | |||
| settings.JS_LIBRARIES.append((0, 'library_wasmfs.js')) | |||
There was a problem hiding this comment.
Did this 0 not ensure that system libs were before user ones?
There was a problem hiding this comment.
Indeed, and that is still that case. All these JS_LIBRARIES.append happen before process_libraries which runs before process_libraries.
There was a problem hiding this comment.
First process libraries should be phase_linker_setup in the comment? If so then yes, that looks right, thanks.
There was a problem hiding this comment.
Yes sorry, fixed commend
kripken
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By delaying the processing of
--js-libraryarguments we avoid having to jump through hoops and store them alongside their ordinal number for half the time.