Add bank switching and document Testing Workflow #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing missing for passing
cpu_instrs.gb
was implementing some basic MBC1 bank switching. I also make the timer be more align with the gameroy emulation, so it does not diverge when running02-interrupts
, even if the test was still passing.I also took a look at mooneye's test roms, but they at least relies on the PPU LY register for functioning, so I will just skip that and go directly to try simulating the entire DMG-CPU soc next, at dmg-sim repo.
I also document my testing workflow, pointing to the tooling I used. I think we can already Close #204.