-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support options.requires fallback for backward compatibility #286
Conversation
techs/bem-xjst.js
Outdated
'enb-bemxjst', this.getName(), 'requires', 'engineOptions.requires', | ||
' It will be removed in v9.0.0.'); | ||
} | ||
engineOptions.requires || (engineOptions.requires = this._requires); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better place for the line is between 136 and 137 =)
techs/bem-xjst.js
Outdated
if (this._requires) { | ||
this.node.getLogger().logOptionIsDeprecated(this.node.unmaskTargetName(this._target), | ||
'enb-bemxjst', this.getName(), 'requires', 'engineOptions.requires', | ||
' It will be removed in v9.0.0.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How not to forget about it when releasing a v9.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue #287
73f9683
to
00a8f02
Compare
🆙 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
test "must pass engineOptions.engineName to bem-xjst"
-
test "must pass engineOptions.requires to bem-xjst"
…and maybe we can extract describe "engineOptions"
here https://github.com/enb/enb-bemxjst/blob/master/test/techs/bemhtml.test.js#L165
00a8f02
to
dffa460
Compare
eb420ad
to
a128856
Compare
* Describes renamed: according to options and tests group * iife test added * dublicate tests removed
09eff3e
to
1552380
Compare
|
No description provided.