WIP: add write approval callbacks for Failsafe values of CS-LPC usecase #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 7, 2025 12:11
… feature. Made implementation of approval mechansim more general towards the device configuration feature.
|
Thanks for starting the work on this. I do now think that the write approval callback API should be used for all writes on any server feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress proposal for adding write approval callbacks for the failsafe values of the CS-LPC usecase.
Code changes should be functional, but are not yet final. Cleanup and thorough testing may still be required.
Fixes/updates from our side should come when I can find the time to do so. If someone wants to use/update this in the meantime, feel free.
Comments/fixes etc are welcome.