Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix create_memory_object_stream not subscriptable at runtime in old anyio versions #2833

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix create_memory_object_stream not subscriptable at runtime in old anyio versions #2833

merged 2 commits into from
Jan 3, 2025

Conversation

graingert
Copy link
Member

@graingert graingert commented Dec 31, 2024 •
edited
Loading

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@graingert graingert changed the title fix not subcriptable at runtime fix not subscriptable at runtime Dec 31, 2024
@graingert graingert mentioned this pull request Dec 31, 2024
Open
@graingert graingert changed the title fix not subscriptable at runtime fix create_memory_object_stream not subscriptable at runtime in old anyio versions Dec 31, 2024
@graingert graingert marked this pull request as ready for review December 31, 2024 21:32
@graingert
Copy link
Member Author

@Kludex probably this needs a test matrix for each anyio version you want to support?

@graingert graingert requested a review from Kludex January 1, 2025 11:24
@Kludex
Copy link
Member

Kludex commented Jan 3, 2025

Were you able to test against anyio 3.4.0?

@graingert
Copy link
Member Author

3.6.2 is the oldest version I could get running

@Kludex
Copy link
Member

Kludex commented Jan 3, 2025

We should change the pinned version then

@graingert
Copy link
Member Author

@Kludex bumped

@graingert graingert merged commit 950f528 into master Jan 3, 2025
5 checks passed
@graingert graingert deleted the fix-subscriptable branch January 3, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @Kludex