Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app-configuration module to store connection strings in Key Vault #44

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Update app-configuration module to store connection strings in Key Vault #44

merged 5 commits into from
Oct 3, 2022

Conversation

MikeEvansLarah
Copy link
Contributor

Also:

  • Fixes issue in key-vault module where deployment would fail if enableDiagnostics was set to false
  • Fixes incorrect parameter name in storage-account

@MikeEvansLarah MikeEvansLarah merged commit b47eb78 into main Oct 3, 2022
@MikeEvansLarah MikeEvansLarah deleted the feature/app-configuration-connection-strings branch October 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesDawson JamesDawson JamesDawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeEvansLarah @JamesDawson