Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with run-build-process composite action & azure/login speed-up #51

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

JamesDawson
Copy link
Contributor

@JamesDawson JamesDawson commented Sep 11, 2024

  • Fixes an issue where certain values were being stored as environment variables rather than step outputs, and therefore were not available as expected later in the process
  • Switches over builds to use our forked version of azure/login with a fix for its slowness, whilst we wait for the official release

Copy link

github-actions bot commented Sep 11, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 35d4034.

♻️ This comment has been updated with latest results.

Copy link

Code Coverage Summary Report - Linux (No TFM)

Summary
Generated on: 09/11/2024 - 08:28:39
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

Copy link

Code Coverage Summary Report - Linux (net8.0)

Summary
Generated on: 09/11/2024 - 08:30:12
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

Copy link

Code Coverage Summary Report - Windows (net8.0)

Summary
Generated on: 9/11/2024 - 8:31:54 AM
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

@JamesDawson JamesDawson changed the title Fix bug with run-build-process composite action Fix bug with run-build-process composite action & azure/login speed-up Sep 11, 2024
@JamesDawson JamesDawson merged commit d52d3f8 into main Sep 11, 2024
15 checks passed
@JamesDawson JamesDawson deleted the feature/fix-build-ca-bug branch September 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants