Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vellum-related composite actions #93

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Update Vellum-related composite actions #93

merged 5 commits into from
Nov 18, 2024

Conversation

JamesDawson
Copy link
Contributor

  • For consistency, switch them over to use the run-scripted-build composite action (rather then their own script invocation)
  • Update run-script-build to support using a custom GitHub access token, when specified via the GH_TOKEN environment variable

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 6bf0b89.

♻️ This comment has been updated with latest results.

HowardvanRooijen
HowardvanRooijen approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@HowardvanRooijen HowardvanRooijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement on the rebuild search index logic!

@github-actions GitHub Actions
Copy link

Code Coverage Summary Report - Linux (No TFM)

Summary
Generated on: 11/18/2024 - 10:51:58
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

@github-actions GitHub Actions
Copy link

Code Coverage Summary Report - Linux (net8.0)

Summary
Generated on: 11/18/2024 - 10:55:27
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

@github-actions GitHub Actions
Copy link

Code Coverage Summary Report - Windows (net8.0)

Summary
Generated on: 11/18/2024 - 10:57:25 AM
Parser: Cobertura
Assemblies: 2
Classes: 2
Files: 2
Line coverage: 100% (4 of 4)
Covered lines: 4
Uncovered lines: 0
Coverable lines: 4
Total lines: 21
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

TestLib - 100%
Name Line Branch
TestLib 100% ****
TestLib.Class1 100%
TestLib.Tests - 100%
Name Line Branch
TestLib.Tests 100% ****
TestLib.Tests.Tests 100%

@JamesDawson JamesDawson merged commit 7e95d12 into main Nov 18, 2024
15 checks passed
@JamesDawson JamesDawson deleted the feature/update-vellum-composite-action branch November 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardvanRooijen HowardvanRooijen HowardvanRooijen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesDawson @HowardvanRooijen