Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

fix: filesystem cache handler with url params #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjastrzebowski
Copy link

Server crashes whenever trying to cache with FileSystemCacheHandler some route with url params, eg. /search?term=test or /category/example?page=4 - might be problem on Windows only as mentioned in #38 that you can't create file with special characters, but IMO in general it would be good to have more safe filenames.

Basically replacing all special characters from route is fixing the main problem, in the future I will also take a look into angular prerendering itself (also breaks on special characters right now) and might need some changes to convertFileNameToRoute method as well.

Solves #38

@vercel
Copy link

vercel bot commented May 5, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @eneajaho on Vercel.

@eneajaho first needs to authorize it.

@mjastrzebowski mjastrzebowski changed the title fix: filesystem cache handler with url params #38 fix: filesystem cache handler with url params May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant