Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for d (days) as an updateInterval suffix #453

Closed
wants to merge 2 commits into from
Closed

fix: add support for d (days) as an updateInterval suffix #453

wants to merge 2 commits into from

Conversation

ylmrx
Copy link
Contributor

@ylmrx ylmrx commented Dec 12, 2024

No description provided.

@ylmrx
Copy link
Contributor Author

ylmrx commented Dec 12, 2024

this solves #451

@ylmrx ylmrx marked this pull request as draft December 12, 2024 17:31
@ylmrx ylmrx force-pushed the fix/catch_unsupported_updateinterval_durations branch from 13e528e to 61ba3bd Compare December 12, 2024 17:31
@ylmrx
Copy link
Contributor Author

ylmrx commented Dec 13, 2024

This change is breaking the generated CRD (metav1.Duration does a lot of work to keep it as a consistent (json) string we can't reliably override)

@ylmrx ylmrx closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ylmrx