Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace older time functions with more portable ones #570

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gargaj
Copy link

@Gargaj Gargaj commented May 17, 2024

@epezent
Copy link
Owner

epezent commented Dec 24, 2024

@Gargaj I think your code is missing an important step:

Portability note: mktime is essentially universally available. timegm is rather rare. For the most portable conversion from a UTC broken-down time to a simple time, set the TZ environment variable to UTC, call mktime, then set TZ back.

@Gargaj
Copy link
Author

Gargaj commented Dec 24, 2024

This has been a while so I don't specifically remember what was being broken, but the functions I was trying to fix were not available on one of the current generation consoles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants