Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formkit): integration module #4435

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from
Open

feat(formkit): integration module #4435

wants to merge 42 commits into from
+3,363 −29

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Nov 25, 2024 •
edited by asvae
Loading

related to #3427

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

👷 Deploy request for vuestic-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4bc48f1

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit 4bc48f1
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/677fc9e60e1f4b000821d6ad
😎 Deploy Preview https://deploy-preview-4435--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m0ksem m0ksem marked this pull request as draft November 26, 2024 14:03
@raichev-dima raichev-dima force-pushed the feat/formkit branch 4 times, most recently from cabb0a2 to 19c9dcd Compare December 2, 2024 15:52
@asvae
Copy link
Member

asvae commented Dec 2, 2024 •
edited
Loading

Let's continue working on that.

m0ksem and others added 18 commits December 17, 2024 16:55
asvae
asvae reviewed Dec 26, 2024
View reviewed changes
packages/ui/package.json Outdated Show resolved Hide resolved
asvae
asvae reviewed Dec 26, 2024
View reviewed changes
packages/ui/src/stories/formkit/Rating.stories.ts Outdated
@@ -0,0 +1,24 @@
import { StoryFn } from '@storybook/vue3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what component is used here, but it shouldn't behave this way.

We should use vuesic rating instead.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4451 should fix the issue

@raichev-dima raichev-dima marked this pull request as ready for review January 9, 2025 15:19
@raichev-dima
Copy link
Member

Note: The Timepicker input exists in the codebase but doesn't work correctly. @asvae lets create a separate issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raichev-dima raichev-dima raichev-dima left review comments

@asvae asvae asvae left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0ksem @asvae @raichev-dima