-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to auto-detect TIRPC=YES #187
base: master
Are you sure you want to change the base?
Conversation
BESSY repo is offline...
✅ Build asyn 1.0.240 completed (commit 3539991644 by @mdavidsaver) |
The Asyn build currently assumes that TIRPC is only needed on Linux, although that doesn't mean other OSs won't ever switch to that in the future. I approve of adding and installing a However static builds of those downstream applications won't necessarily know about tirpc if they don't call it directly (the synApps SSCAN module does, I've had to add a TIRPC flag to that for our RHEL-8 builds), but they will need to know whether to link their executables with the |
Yup, I know. I see this PR as a first small step towards dealing with a complication which has perhaps become the number one new user obstacle reported on tech-talk. (maybe a close second to CA timeout due to firewall) fyi. I have to confront a similar situation with static linking wrt. libevent in the PVXS build. cf. CONFIG_PVXS_MODULE and |
I am also thinking about ways to give a better error when #ifdef __has_include
# if !__has_include(<rpc/rpc.h>)
# error Missing rpc/rpc.h. Try "apt-get install libtirpc-dev" or "dnf install tirpc-devel"
# endif
#endif |
Also, I feel bound to point out that this PR, and any which may follow, are in effect re-inventing functionality which is present in all ~modern C/C++ build tools. Anything I do here will almost certainly be less comprehensive than eg. cmake |
Attempts to detect when
TIRPC=YES
is needed. Currently only in the limited case where the host architecture is Linux.Also, remove SNCSEQ from the CI builds as the BESSY site is still offline.