Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix input placeholder bug & improve handling #458

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

JoeArmani
Copy link
Contributor

Related: episphere/questionnaire#344

• Use evaluateCondition for placeholder evaluation (bug fix - evaluation formulas in placeholder field)
• Limit placeholder evaluation for large range values e.g. weight (max=999) and age (max=125). Show the default 'Enter a value' placeholder in those cases.

Screenshot 2024-09-12 at 10 14 16 AM Screenshot 2024-09-12 at 10 22 13 AM

Copy link
Member

@danielruss danielruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anthonypetersen
Copy link
Contributor

@JoeArmani want to sync this into quest-dev?

@JoeArmani JoeArmani merged commit 4630f6a into main Sep 13, 2024
@JoeArmani JoeArmani deleted the placeholder-bug branch September 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants