Revise all Age-related range checks in Baseline Modules 1-4

[cusackjm]

Module 1 range checks are updated in the Qx documents

[cusackjm]

Module 4 range checks are updated in the Qx documents

[cusackjm]

Module 3 range checks are updated in the Qx documents

[cunnaneaq]

Module 2 range checks are updated in the Qx documents

[cusackjm]

Sorry- we have to update the range checks to a different formula. Please put all of this on hold.

[boyd-mj]

Noted, thanks.

[cusackjm]

@boyd-mj Range checks have been updated in the Baseline Modules 1-4 questionnaire documents and are ready for programming. Let me know if you have any questions

[joshid-ims]

@cusackjm is RcrtUP_YOB_v1r0 coming from other system like age?

[cusackjm]

yes, similar to how age was pulled

[joshid-ims]

Thanks. And is it always going to be present? Or is it an optional question?

[cusackjm]

RcrtUP_YOB_v1r0 comes from the User Profile that participants complete when they sign up

[joshid-ims]

I mean, while coding do I need to check if the value if present or will it always be present?

[cusackjm]

@joshid-ims the value will always be present

[joshid-ims]

Ok, thanks!

[joshid-ims]

SrvMRE_FirstPeriodAge_v1r0 - where is it coming from?

I am not sure if we can add conditionals in min max range checks.

@anthonypetersen @Davinkjohnson @cusackjm

Not sure if this can be implemented:

[RANGE CHECK min= SrvSAS_AgeCigsUseF_v1r0 IF SrvSAS_AgeCigsUseF_v1r0 HAS A RESPONSE, or min= 0 if SrvSAS_AgeCigsUseF_v1r0 IS NULL, max= (Current year - RcrtUP_YOB_v1r0 +1)]

[cusackjm]

number entered at MENSHIS

[danielruss]

[AGE] How old RU |__|__|min=30 max=100|

[MOMCANC3C] How old was your mother when they were <b>first</b> told by a doctor or other health professional that they have or had <b>brain cancer</b>?<br/>
|__|__|__|xor=MOMCANC3C id=MOMCANC3C_AGE min=0,
max=_value("AGE")| Age at diagnosis

[END] bye...

[woodruffr]

@cunnaneaq and @m-j-horner The data dictionary has in the Notes column that the Range check min =0 and max=999999. Is this something that NCI will be updating to minlen and maxlen?

[cunnaneaq]

@woodruffr I can make that update in the DD as I'm making the other baseline mod edits

[JoeArmani]

@joshid-ims The placeholder text issue should be resolved, thanks.

[joshid-ims]

Thanks! We will test it.

[joshid-ims]

This is resolved.

[joshid-ims]

The original issue of range checks is not complete yet.

[joshid-ims]

Age range changes are missed for questions SMMAR2, EAMAR2, ALCOHOL3 and TANBED2 in Module 3. I saw in English. Will add a comment when I work on Spanish survey.

[joshid-ims]

I do not see these age range changes in Spanish yet for Module3. They are not made yet, right?

[boyd-mj]

@joshid-ims I see the changes in the document on Box, which shows that it was updated on 10/8:
https://app.box.com/file/1609804079931

[joshid-ims]

Sorry, had older version open. I see them. Thanks!

[joshid-ims]

LIFE and grid age ranges to be updated in Module 3 Spanish.

[woodruffr]

I see there is a M2 issue for Age Range checks so will be putting the issues found in #422.

[cunnaneaq]

I added "NOTE FOR PROGRAMMERS: CURRENT AGE = age" for all LIFE and grid question in mod 3 English and Spanish documents

[joshid-ims]

Thanks!

[woodruffr]

Posting this here since it was put into a related Github issue: When testing surveys with the RCRTUP_YOB_V1R1 variable, it comes from the user profile and this format is used in the Previous Results section of the renderer:

[anthonypetersen]

@woodruffr just a heads up - we will be adding a variable similar to "age" that will come from the "pwa" called "yob". It will hold the year of birth of the participant. We will not be passing in the variable using the variable name from the data dictionary.

[woodruffr]

@anthonypetersen, Does that mean that for Dev and Stage, wherever RCRTUP_YOB_V1R0 shows up it will automatically pull from the YOB?

[anthonypetersen]

@woodruffr - no, the markdown will need to reference yob. We aren't going to be passing a variable called RCRTUP_YOB_V1R0 into Quest from the PWA.

[woodruffr]

@anthonypetersen , so then will the renderer recognize YOB? @m-j-horner if this is to be YOB in the mark-up, we will need to be able to test that in the renderer, and the Questionnaires will need to be updated for what should be in the code.

[anthonypetersen]

@woodruffr if you are testing in the renderer you need to manually add all variables you'd expect to come from the PWA into Previous Results

[cunnaneaq]

@woodruffr this came to light yesterday, Marie-Josephe and I discussed and I will make the updates in the questionnaire documents. This function is in dev, so when the questionnaire docs and markup are finished being updated, it will be available for testing

[cunnaneaq]

I updated the year range checks in the module 1,2,&4 English and Spanish questionnaire documents to account for the yob update in #424

[woodruffr]

We have reviewed these. All instances where there was RcrTUP_YOB_v1r0 in M1, M2, and M4, now have yob. This is a low-priority fix, but want to document it so that it gets corrected at some point. Many of the M4 Spanish fixes got double commas or are missing a period or comma, i.e.,:

[cunnaneaq]

I cleaned up the spacing and commas in Spanish M4 doc for the yob range checks

[huip-ims]

YOB changes have been made to English and Spanish M1 & M2 and are in queue for IMS internal testing. M4 content changes are ongoing.