Added checkbox for important tasks in default configuration #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
May 8, 2024
There was a problem hiding this comment.
This looks good, thanks @david-0609. I actually already have something similar in my personal config. Can you just update the config example in the README? Then we'll get this merged.
I updated the example config in the README, you can merge now |
epwalsh
reviewed
May 16, 2024
| @@ -463,6 +463,7 @@ This is a complete list of all of the options that can be passed to `require("ob | |||
| ["x"] = { char = "", hl_group = "ObsidianDone" }, | |||
| [">"] = { char = "", hl_group = "ObsidianRightArrow" }, | |||
| ["~"] = { char = "", hl_group = "ObsidianTilde" }, | |||
| ["!"] = { char = "", hl_group = "ObsidianImportant" }, | |||
There was a problem hiding this comment.
This HL group also needs to be defined below.
There was a problem hiding this comment.
HL Group has been updated in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people use Obsidian to organise their tasks using checkboxes and I added a checkbox to the default configuration that indicates that the task is important. I also added a highlight group ("ObsidianImportant") that uses a darker red colour. Also I shifted the order for toggle checkboxes to make this checkbox make sense in terms of order.