Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a select all feature #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nathan-Roberts123
Copy link
Contributor

@Nathan-Roberts123 Nathan-Roberts123 commented Jan 15, 2024

What issue does this pull request resolve?
This will pull request will add a new feature that was requested by users, this feature allows a user to click on a select all button to select all options in a multiple select input. Issue #821

What changes did you make?
I added a button to select all options in a multiple input options menu, and I created the function to handle that click and add all options to selectedOptions array. I also wrote a test for the feature.

Is there anything that requires more attention while reviewing?
No, I don't think there is.

@Nathan-Roberts123
Copy link
Contributor Author

select_all_inage The feature looks something like this.

@namti
Copy link

namti commented Jan 14, 2025

Any updates of this pull request? Would be great if this feature is considered.

@ericgio
Copy link
Owner

ericgio commented Jan 16, 2025

@namti Unlikely that I will add this specific feature since the functionality is already possible via a workaround. In general, I'm trying to avoid one-off features or solutions that don't scale for other use cases. I should actually look into generalizing the pagination option to allow for any kind of custom item + behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants