Replace www erlang links #68

eksperimental · 2022-01-19T13:46:42Z

First take on #66, let's see what Netlify finds

netlify · 2022-01-19T13:46:49Z

❌ Deploy Preview for erlang-org failed.

🔨 Explore the source changes: 4a60273

🔍 Inspect the deploy log: https://app.netlify.com/sites/erlang-org/deploys/61e86b6dc288e400088bba06

eksperimental · 2022-01-19T13:47:35Z

@garazdawi please have a look at the changes in commit 5df2f80

garazdawi

doc/search         /doc

Is actually wrong in the redirect and should be removed. I hadn't noticed it as netlify does not redirect any URLs that it can serve, and /doc/search does exist. So 5df2f80 should not be done.

garazdawi · 2022-01-19T13:54:06Z

_news/101.md



 You can also read the documentation on-line here: 
 (see the Release Notes mentioned above for release notes which 
 are not updated in the doc, but the new functionality is)

-[https://www.erlang.org/doc/](/doc/)


This is incorrect.

_news/105.md

garazdawi · 2022-01-19T14:09:11Z

_news/105.md

@@ -44,7 +44,7 @@ Some highlights of the release are:
 (see the Release Notes mentioned above for release notes which
 are not updated in the doc, but the new functionality is)

-<https://www.erlang.org/doc>


this is incorrect

isn't this still incorrect?

garazdawi · 2022-01-19T14:09:43Z

_news/107.md

@@ -23,9 +23,9 @@ Some highlights of the release are:

 You can find the Release Notes with more detailed info at

-<https://www.erlang.org/download/otp_src_19.1.readme>


keep the www

But it is redirecting to erlang.org

doc/search /doc

Is actually wrong in the redirect and should be removed. I hadn't noticed it as netlify does not redirect any URLs that it can serve, and /doc/search does exist. So 5df2f80 should not be done.

So should it discard the two commits that replace /doc/search ?

But it is redirecting to erlang.org

www.erlang.org should have better uptime than erlang.org, so I would like to have links pointing to it as a first step. That way if we ever move any of the contents from erlang.org to www.erlang.org we will not have to rely on erlang.org to redirect us to the correct place.

So should it discard the two commits that replace /doc/search ?

yes. Feel free to remove the redirect rule from _redirects as well.

ok. I will do it in a different PR

But it is redirecting to erlang.org

www.erlang.org should have better uptime than erlang.org, so I would like to have links pointing to it as a first step. That way if we ever move any of the contents from erlang.org to www.erlang.org we will not have to rely on erlang.org to redirect us to the correct place.

Should this apply to everything, or just downloads?

I mean, should this apply to all the first set of rules in _redirects ?

Ok. I have left the _redirects as the single source of truth, nothing in the site links to https://erlang.org now
I think it reduces the cognitive overhead A LOT

garazdawi · 2022-01-19T14:09:53Z

_news/107.md



 You can also read the documentation on-line here:
 (see the Release Notes mentioned above for release notes which
 are not updated in the doc, but the new functionality is)

-[https://www.erlang.org/doc/](/doc/)


the display link you still be https://www.erlang.org/... ?

yes, exactly. The link should point to /some/thing/, but what is displayed should be the full path.

garazdawi · 2022-01-19T14:11:09Z

_news/19.md

@@ -11,7 +11,7 @@ visible: "true"
 article_type_id: "3"
 ---

- We are aware that parts of erlang.org need improvement. For example <https://www.erlang.org/article/tag/examples> and <https://www.erlang.org/course/course.html> are outdated. We would like to see a number of small code examples for beginners. The purpose of these examples is to provide an attractive and useful introduction for people who are interested in adopting the Erlang programming language. 
+ We are aware that parts of erlang.org need improvement. For example </article/tag/examples> and <https://erlang.org/course/course.html> are outdated. We would like to see a number of small code examples for beginners. The purpose of these examples is to provide an attractive and useful introduction for people who are interested in adopting the Erlang programming language. 


/article/tag/examples was removed in the new erlang.org version, so keep this as a dead link.

garazdawi · 2022-01-19T14:11:36Z

_news/30.md

@@ -23,7 +23,7 @@ article_type_id: "3"

 The release contains many changes; thus, some unexpected incompatibilities or issues may have slipped through our tests. Please try to build and run your current products/applications and let us know about any problems.

- Note! The new datatype MAP is not properly documented yet but the EEP 43 https://www.erlang.org/eeps/eep-0043.html will provide a good start. Also note that it is a limited implementation of maps implemented so far:


As per discussed in erlang#68 (comment)

eksperimental · 2022-01-19T19:40:51Z

@garazdawi please have a look now.
What I have done is link everywhere to https://www.erlang.org and the _redirects file is the single source of truth to redirect to https://erlang.org.

garazdawi

I've not gone though all the changes, but I've added notes on a couple so that you can see what type of changes need to be made.

garazdawi · 2022-01-20T08:38:26Z

README.md

@@ -40,8 +40,8 @@ For instructions on how to run with vscode devcontainers see: <https://code.visu

 Most pages are either html or markdown pages so they can be edited directly. They
 are located in the at the same place as the URL. So, for instance, the `/about` URL
-is implemented by [/about.md](/about.md) and `/community/euc` is implemented in
-[/community/euc](/community/euc.md).


This should not have the erlang.org prefix as it is a link in the github repo

garazdawi · 2022-01-20T08:40:37Z

_includes/downloads-sidebar.html

@@ -40,7 +40,7 @@
                {% endfor %}
            </ul>
            <small>Older releases and a file containing MD5 checksums for all files in the
-                <a href="https://erlang.org/download">download directory</a>,


this should not be rewritten

garazdawi · 2022-01-20T08:41:02Z

_news/10.md


- Download the new release from the [download page](https://erlang.org/download.html).


this should not be rewritten

garazdawi · 2022-01-20T08:41:52Z

_news/105.md

@@ -44,7 +44,7 @@ Some highlights of the release are:
 (see the Release Notes mentioned above for release notes which
 are not updated in the doc, but the new functionality is)

-<https://www.erlang.org/doc>


isn't this still incorrect?

garazdawi · 2022-01-20T08:42:35Z

_news/109.md

@@ -21,14 +21,14 @@ Some highlights for 19.2

 You can find the README and the full listing of changes for this service release at

-  https://www.erlang.org/download/otp_src_19.2.readme


this should not be rewritten, but could have a < tag around the link

garazdawi · 2022-01-20T08:42:45Z

_news/109.md

-  https://www.erlang.org/download/otp_src_19.2.tar.gz
-  https://www.erlang.org/download/otp_win32_19.2.exe
-  https://www.erlang.org/download/otp_win64_19.2.exe


this should not be rewritten, but could have a < tag around the link

garazdawi · 2022-01-20T08:42:58Z

_news/109.md

@@ -37,11 +37,11 @@ For installation instructions please consult the README file that is part of th
 The Erlang/OTP source can also be found at GitHub on the official Erlang
 repository, https://github.com/erlang/otp with tag OTP-19.2

-The on-line documentation can be found at: https://www.erlang.org/doc/


this should not be rewritten, but could have a < tag around the link

garazdawi · 2022-01-20T08:43:06Z

_news/109.md

-  https://www.erlang.org/download/otp_doc_html_19.2.tar.gz
-  https://www.erlang.org/download/otp_doc_man_19.2.tar.gz


this should not be rewritten, but could have a < tag around the link

garazdawi · 2022-01-20T08:44:10Z

_news/13.md

@@ -16,7 +16,7 @@ article_type_id: "3"

 See the release notes in the [readme file](https://www.erlang.org/download/otp_src_R14B04.readme).

- Download the new release from the [download page](https://www.erlang.org/download.html).


this should not be rewritten

garazdawi · 2022-01-20T08:44:41Z

_news/132.md


 Online documentation can be browsed here:
-[https://erlang.org/doc/search/](/doc/search/)


This should only add the www prefix, the link should be as is.

garazdawi requested changes Jan 19, 2022

View reviewed changes

eksperimental force-pushed the replace_www_erlang_links branch 2 times, most recently from e92b205 to 2e7bbd9 Compare January 19, 2022 18:18

eksperimental added 12 commits January 19, 2022 13:41

Fix broken links in News

910fb2b

Replace links to https://www.erlang.org/ with /

6c2a01f

Replace redirect links to https://erlang.org

189fec4

Replace blog links

f224bf3

Replace https://bugs.erlang.org/browse/ with /bugs/

c02cea4

Replace link to issue tracker

ca82e3d

Replace links to https://erlang.org/doc/ with /doc/

e3da835

Replace /erlang-enhancement-proposals/ with /eeps/

a3b4493

Replace https://erlang.org/eeps/ with /eeps/

8554a56

Fix links

fae7686

Simplify more links

ee371c2

eksperimental force-pushed the replace_www_erlang_links branch from fd43031 to ee371c2 Compare January 19, 2022 18:41

eksperimental added a commit to eksperimental-forks/erlang-org that referenced this pull request Jan 19, 2022

Remove /doc/search redirect

da1cf9c

As per discussed in erlang#68 (comment)

eksperimental mentioned this pull request Jan 19, 2022

Remove /doc/search redirect #70

Merged

eksperimental added 3 commits January 19, 2022 14:25

Replace httsp://erlang.org/ with https://www.erlang.org/ for links th…

dab8f81

…at redirect to https://erlang.org Replace "(https:\/\/erlang.org\/)(download|~|course|documentation|mailman|mailman-icons|pipermail)\/" with "https:\/\/www.erlang.org\/\2\/" See discussion: erlang#68 (comment)

Replace old link to download

dbd86bf

Add erlang.org/workshop redirect

03d521e

eksperimental added 2 commits January 19, 2022 14:49

Correct remaining urls so we always use https://www.erlang.org/download/

f37a6c8

Use https://www.erlang.org everywhere!

4a60273

eksperimental force-pushed the replace_www_erlang_links branch from 3a28f75 to 4a60273 Compare January 19, 2022 19:50

garazdawi requested changes Jan 20, 2022

View reviewed changes

		@@ -23,9 +23,9 @@ Some highlights of the release are:

		You can find the Release Notes with more detailed info at

		<https://www.erlang.org/download/otp_src_19.1.readme>

		@@ -23,7 +23,7 @@ article_type_id: "3"

		The release contains many changes; thus, some unexpected incompatibilities or issues may have slipped through our tests. Please try to build and run your current products/applications and let us know about any problems.

		Note! The new datatype MAP is not properly documented yet but the EEP 43 https://www.erlang.org/eeps/eep-0043.html will provide a good start. Also note that it is a limited implementation of maps implemented so far:


		Download the new release from the [download page](https://erlang.org/download.html).

		@@ -21,14 +21,14 @@ Some highlights for 19.2

		You can find the README and the full listing of changes for this service release at

		https://www.erlang.org/download/otp_src_19.2.readme

		https://www.erlang.org/download/otp_doc_html_19.2.tar.gz
		https://www.erlang.org/download/otp_doc_man_19.2.tar.gz

		@@ -16,7 +16,7 @@ article_type_id: "3"

		See the release notes in the [readme file](https://www.erlang.org/download/otp_src_R14B04.readme).

		Download the new release from the [download page](https://www.erlang.org/download.html).


		Online documentation can be browsed here:
		[https://erlang.org/doc/search/](/doc/search/)

Replace www erlang links #68

Are you sure you want to change the base?

Replace www erlang links #68

Conversation

eksperimental commented Jan 19, 2022

netlify bot commented Jan 19, 2022 • edited Loading

eksperimental commented Jan 19, 2022

garazdawi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eksperimental Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eksperimental Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eksperimental commented Jan 19, 2022

garazdawi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Jan 19, 2022 •

edited

Loading

eksperimental Jan 19, 2022 •

edited

Loading

eksperimental Jan 19, 2022 •

edited

Loading