Support delayed delivery (XEP-0203, XEP-0091). #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paurkedal
pushed a commit
to paurkedal/erm_xmpp
that referenced
this pull request
Jul 21, 2015
Support delayed delivery (XEP-0203, XEP-0091).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for the element, which is required to get the correct time when e.g. receiving history form the chatroom. There is a new and a legacy standard; the ejabberd version I'm using myself uses legacy, so I had to add that, as well.
I did not attempt to parse the dates, but instead pass the stamp string verbatim to the client callback. If it's okay to depend on the Unix module or some external calendar library, I can change the commit to parse the dates into an float (seconds since Epoch). I think that makes the "delay_legacy" field unnecessary.
(A dependency on some date providing module may also be relevant for formatting the ~since parameter for MUC, which should be an XMPP date string.)