-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Leumi login selector #825
Conversation
So does that mean that it's fixed for Bank Leumi? |
@michlus It is Pull Request that is pending approval in order to fix the issue. When it will be approve it will be merge and release in the next version |
@itairaz1 got it; thank you very much. |
Hi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I approve this change.
Most of the time we prefer to hear the problem is reproduced for more users, and there is another one except you that this change is working for him.
🎉 This PR is included in version 4.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks very much.
I ignore why it wasn’t a problem for all users , but anyways - I can confirm that the problem is indeed solved.
Thanks !
Michel
…________________________________
From: Baruch Odem (Rothkoff) ***@***.***>
Sent: Tuesday, January 30, 2024 8:47:08 AM
To: eshaham/israeli-bank-scrapers ***@***.***>
Cc: michlus ***@***.***>; Mention ***@***.***>
Subject: Re: [eshaham/israeli-bank-scrapers] fix: Leumi login selector fix (PR #825)
@baruchiro approved this pull request.
Hi, I approve this change.
Most of the time we prefer to hear the problem is reproduced for more users, and there is another one except you that this change is working for him.
—
Reply to this email directly, view it on GitHub<#825 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2NYV2F5OCCSVA6T6KFHMTTYRCJOZAVCNFSM6AAAAABB3ZFEGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJQGM2DAOJQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I created a list of Code Owners to get PRs verified quickly, you're welcome to join. See #830 |
No description provided.