Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preproc hilbert + rectification + FIRWS tests #264

Merged
merged 19 commits into from
Apr 12, 2022
Merged

Preproc hilbert + rectification + FIRWS tests #264

merged 19 commits into from
Apr 12, 2022

Conversation

tensionhead
Copy link
Contributor

Author Guidelines

  • Is the change set < 400 lines?
  • Was the code checked for memory leaks/performance bottlenecks?
  • Is the code running locally and on the ESI cluster?
  • Is the code running on all supported platforms?

Reviewer Checklist

  • Are testing routines present?
  • Do parallel loops have a set length and correct termination conditions?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Do code-blocks provide novel functionality, i.e., no re-factoring using builtin/external packages possible?
  • Code layout
    • Is the code PEP8 compliant?
    • Does the code adhere to agreed-upon naming conventions?
    • Are keywords clearly named and easy to understand?
    • No commented-out code?
  • Are all docstrings complete and accurate?

tensionhead added 13 commits April 1, 2022 11:17
@tensionhead
WIP: Rectify
3f5c1b1 
Changes to be committed:
	modified:   syncopy/preproc/compRoutines.py
	modified:   syncopy/preproc/preprocessing.py
@tensionhead
WIP: Attach rectified data to filtered data object
b64b5a6 
- probably not the best idea..

Changes to be committed:
	modified:   syncopy/preproc/preprocessing.py
@tensionhead
Merge pull request #256 from esi-neuroscience/preproc-tests
5b5c84e 
Merge Preproc tests into rectify/hilbert branch
@tensionhead
NEW: Rectification after filtering
eb2beed 
- new flag `rectify` for the preprocessing frontend

Changes to be committed:
	modified:   syncopy/preproc/compRoutines.py
	modified:   syncopy/preproc/preprocessing.py
@tensionhead
NEW: Hilbert transform for preprocessing
5055a05 
- supports all output types of FT

Changes to be committed:
	modified:   syncopy/preproc/compRoutines.py
	modified:   syncopy/preproc/preprocessing.py
@tensionhead
FIX: Exclude hilber and rectify from effective parameter checks
61367de 
Changes to be committed:
	modified:   syncopy/preproc/preprocessing.py
@tensionhead
Merge pull request #261 from esi-neuroscience/preproc-tests
028d736 
Update from Preproc tests
@tensionhead
NEW: Test Hilbert and Rectification
43fc20d 
- after butterworth filtering
@tensionhead
CHG: Wrapping try/except blocks in a boolean
97912df 
- we should also make sure, that such try/except blocks
really do reach the exception..

Changes to be committed:
	modified:   syncopy/tests/test_preproc.py
@tensionhead
FIX: Captured a case where the exception was not triggered
b4b8756 
- test_but_kwargs now tests for all 3 cases for the order parameter

Changes to be committed:
	modified:   syncopy/tests/test_preproc.py
@tensionhead
Merge pull request #262 from esi-neuroscience/preproc-tests
754935a 
Preproc tests
@tensionhead
NEW: FIRWS and Hilbert + Recitification tests
e64c8dd 
- mostly recycled Butterworth tests for firws

Changes to be committed:
	modified:   syncopy/preproc/compRoutines.py
	modified:   syncopy/tests/test_preproc.py
@tensionhead
Merge branch 'dev' into preproc-hilbertrect
07353b9
@tensionhead tensionhead added the Tests Test need to be written for the issue/feature label Apr 11, 2022
@tensionhead tensionhead added this to the preproc milestone Apr 11, 2022
@tensionhead tensionhead requested a review from pantaray April 11, 2022 10:38
@tensionhead
CHG: Relax wilson convergence
d130a37 
- locally an accuracy of 1e-12 was no problem, not sure what is
happening but maybe this helps
@tensionhead
CHG: Relax wilson tests
d95c2e1
pantaray
pantaray reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@pantaray pantaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature addition and clever use of "nested" computeFunction calls.

syncopy/preproc/compRoutines.py Show resolved Hide resolved
syncopy/preproc/preprocessing.py Outdated Show resolved Hide resolved
syncopy/preproc/preprocessing.py Show resolved Hide resolved
syncopy/preproc/preprocessing.py Show resolved Hide resolved
syncopy/preproc/preprocessing.py Show resolved Hide resolved
syncopy/tests/test_preproc.py Outdated Show resolved Hide resolved
syncopy/tests/test_preproc.py Outdated Show resolved Hide resolved
syncopy/tests/test_preproc.py Outdated Show resolved Hide resolved
syncopy/tests/test_preproc.py Outdated Show resolved Hide resolved
syncopy/tests/test_preproc.py Show resolved Hide resolved
tensionhead and others added 3 commits April 11, 2022 16:34
@tensionhead
PR fixes
2a23102 
Changes to be committed:
	modified:   syncopy/preproc/preprocessing.py
	modified:   syncopy/tests/test_preproc.py
@pantaray
CHG: Fixed typos
7885860 
- capitalized Hilbert

 On branch preproc-hilbertrect
 Changes to be committed:
	modified:   syncopy/preproc/compRoutines.py
	modified:   syncopy/preproc/preprocessing.py
@pantaray
Merge branch 'preproc-hilbertrect' of github.com:esi-neuroscience/syn…
b6ac204 
…copy into preproc-hilbertrect
@tensionhead tensionhead mentioned this pull request Apr 12, 2022
Open
@pantaray
Copy link
Member

Good to merge from my end!

@tensionhead
CHG: Relax wilson convergence
3bf4d8e 
- even though we have extremely good precision with Mukesh' input now,
the convergence for our own test data got worse :/

Changes to be committed:
	modified:   syncopy/nwanalysis/wilson_sf.py
	modified:   syncopy/tests/backend/test_conn.py
@tensionhead tensionhead merged commit 83358de into dev Apr 12, 2022
@tensionhead tensionhead deleted the preproc-hilbertrect branch April 13, 2022 12:33
@pantaray pantaray restored the preproc-hilbertrect branch April 13, 2022 12:45
@tensionhead tensionhead deleted the preproc-hilbertrect branch April 22, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pantaray pantaray pantaray left review comments

Assignees
No one assigned
Labels
Tests Test need to be written for the issue/feature
Projects
None yet
Milestone
preproc
Development

Successfully merging this pull request may close these issues.
2 participants
@tensionhead @pantaray