Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

529 Make pynwb optional dependency #530

Merged
merged 7 commits into from
Jun 29, 2023
Merged

529 Make pynwb optional dependency #530

merged 7 commits into from
Jun 29, 2023

Conversation

dfsp-spirit
Copy link
Collaborator

@dfsp-spirit dfsp-spirit commented Jun 28, 2023

Changes Summary

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit changed the base branch from master to dev June 28, 2023 14:07
@dfsp-spirit dfsp-spirit changed the title 529 pynwb conda 529 Make pynwb optional dependency Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.04 🎉

Comparison is base (0ad96b6) 68.99% compared to head (53f55c4) 69.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #530      +/-   ##
==========================================
+ Coverage   68.99%   69.03%   +0.04%     
==========================================
  Files          87       87              
  Lines       10081    10103      +22     
  Branches     2112     2120       +8     
==========================================
+ Hits         6955     6975      +20     
+ Misses       2550     2544       -6     
- Partials      576      584       +8     
Impacted Files Coverage Δ
syncopy/datatype/continuous_data.py 79.11% <37.50%> (-0.94%) ⬇️
syncopy/datatype/discrete_data.py 80.86% <40.00%> (-0.70%) ⬇️
syncopy/io/load_nwb.py 54.38% <40.00%> (-0.53%) ⬇️
syncopy/io/nwb.py 83.54% <83.33%> (-0.67%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dfsp-spirit dfsp-spirit marked this pull request as ready for review June 29, 2023 09:55
@dfsp-spirit dfsp-spirit merged commit 528a69b into dev Jun 29, 2023
@dfsp-spirit dfsp-spirit deleted the 529_pynwb_conda branch July 5, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant