Increase emac_rx stack size #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
pushed a commit
that referenced
this pull request
Jan 1, 2025
* gatekeep mdns ipv6 behind feature flag * fix feature flag typo * format * requested changes * erratum * add ipv4 feature flag * add wrapper for promiscuous mode * change warn->info * add changes * add changes * &mut self -> &self * add documentation, switch to &mut self * format * double emac_rx stack size * Revert "double emac_rx stack size" This reverts commit 54b89b1. * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
Currently, on my end, increasing log verbosity beyond info with ethernet enabled crashes with a stack overflow in the emac_rx task. This simply increases the stack size of the task to prevent the crash.
Additionally, this reflects the default for the esp-idf project.
Unless i'm mistaken there is no kconfig setting that can be set to move this value.
Testing
Tested on my end with log set to debug level, crashes don't occur anymore.