-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source_ipv4, source_ipv6 functions in EspHttpRawConnection #539
Conversation
Huh. Clippy doesn't complain on 5.2.3 but does on 5.1.2. What's going on here? |
mod c_char_definition {
cfg_if! {
// These are the targets on which c_char is unsigned.
if #[cfg(any(
all(
target_os = "linux",
any(
target_arch = "aarch64",
target_arch = "arm",
target_arch = "hexagon",
target_arch = "powerpc",
target_arch = "powerpc64",
target_arch = "s390x",
target_arch = "riscv64",
target_arch = "riscv32",
target_arch = "csky"
)
),
all(target_os = "android", any(target_arch = "aarch64", target_arch = "arm")),
all(target_os = "l4re", target_arch = "x86_64"),
all(
any(target_os = "freebsd", target_os = "openbsd"),
any(
target_arch = "aarch64",
target_arch = "arm",
target_arch = "powerpc",
target_arch = "powerpc64",
target_arch = "riscv64"
)
),
all(
target_os = "netbsd",
any(
target_arch = "aarch64",
target_arch = "arm",
target_arch = "powerpc",
target_arch = "riscv64"
)
),
all(
target_os = "vxworks",
any(
target_arch = "aarch64",
target_arch = "arm",
target_arch = "powerpc64",
target_arch = "powerpc"
)
),
all(
target_os = "fuchsia",
any(target_arch = "aarch64", target_arch = "riscv64")
),
all(target_os = "nto", target_arch = "aarch64"),
target_os = "horizon",
target_os = "aix",
))] {
pub type c_char = u8;
} else {
// On every other target, c_char is signed.
pub type c_char = i8;
}
}
} So i'm pretty sure this is what's causing the problem. Do I just paste that cfg in the offending places? That's gonna be ugly |
UUuuuh everything just broke locally and on the CI, what's going on with the sys crate?
|
Ah, you broke it I think |
Should be OK now. |
Is there an easy way to make an empty commit that forces the CI to re-run? |
I'll just bite the bullet and merge as-is. If it breaks the build, I'll fix, no worries. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo fmt
command to ensure that all changed code is formatted correctly.cargo clippy
command to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.md
in the proper section.Pull Request Details 📖
Description
My attempt at #538. It works flawlessly on my end.
Testing
fixes #538