Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embassy-time-driver V0.2 impl #548

Merged
merged 1 commit into from
Jan 15, 2025
Merged

embassy-time-driver V0.2 impl #548

merged 1 commit into from
Jan 15, 2025

Conversation

ivmarkov
Copy link
Collaborator

@ivmarkov ivmarkov commented Jan 6, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • [v] I have updated existing examples or added new ones (if applicable).
  • [v] I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • [v] I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • [v] My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

An embassy-time-driver implementation compatible with the just-released backwards-incompatible embassy-time-driver V0.2.

Testing

With a custom example that unfortunately cannot be pushed, or else esp-idf-svc would non-optionally depend on embassy-time, which is not ideal.

@ivmarkov ivmarkov force-pushed the embassy-time-driver-02 branch from 94d697b to f36bf21 Compare January 6, 2025 10:48
src/timer.rs Show resolved Hide resolved
@ivmarkov ivmarkov force-pushed the embassy-time-driver-02 branch from f36bf21 to 1f86a57 Compare January 11, 2025 07:22
@ivmarkov ivmarkov merged commit 024c4cc into master Jan 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants