Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Optimized parts of the code in the gatt_server_service_table example. (IDFGH-11491) #12618

Closed
wants to merge 1 commit into from

Conversation

TritiumXs
Copy link

I found some redundancy in certain parts of the code, so I made modifications by removing redundant segments. These changes do not affect the functionality of the code.

Copy link

github-actions bot commented Nov 17, 2023

Messages
📖 Good Job! All checks are passing!

👋 Welcome TritiumXs, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against 1861fbc

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 17, 2023
@github-actions github-actions bot changed the title example: Optimized parts of the code in the gatt_server_service_table example. example: Optimized parts of the code in the gatt_server_service_table example. (IDFGH-11491) Nov 17, 2023
@TritiumXs TritiumXs closed this Nov 20, 2023
@TritiumXs TritiumXs reopened this Nov 20, 2023
@esp-zhp
Copy link
Collaborator

esp-zhp commented Nov 20, 2023

Thank you for your feedback. The reason for writing it this way is primarily to emphasize the independence of the contents of adv_data and scan_rsp_data, aiming to prevent any potential misunderstanding on the part of the users.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Nov 20, 2023
@TritiumXs
Copy link
Author

Thank you for your feedback. The reason for writing it this way is primarily to emphasize the independence of the contents of adv_data and scan_rsp_data, aiming to prevent any potential misunderstanding on the part of the users.

Okay, but the explanation for "scan_rsp_data.p_service_data" isn't the same as for "adv_data." This is a minor detail, but if this issue can be corrected, I believe it can be improved.

@esp-zhp
Copy link
Collaborator

esp-zhp commented Nov 20, 2023

Yes, we will further improve this area in the future. Do you find any other parts of the documentation unclear? We would greatly appreciate your feedback.

@TritiumXs
Copy link
Author

Yes, we will further improve this area in the future. Do you find any other parts of the documentation unclear? We would greatly appreciate your feedback.

Oh, indeed, there are some suggestions. UUIDs are really hard to remember. I think we can define a macro, allowing users to initialize using this macro and then modify it according to their needs. Also, the explanation for "raw_adv_data" in this example isn't very clear and may not be very friendly for developers new to BLE. I hope it can be supplemented more comprehensively.

@esp-zhp
Copy link
Collaborator

esp-zhp commented Nov 20, 2023

Alright, I will explain the format of raw_scan_rsp_data in the document later to make it easier for beginners to understand.

@TritiumXs TritiumXs closed this Nov 20, 2023
@TritiumXs
Copy link
Author

Alright, I will explain the format of raw_scan_rsp_data in the document later to make it easier for beginners to understand.

And I found that the macro for "appearance" has already been defined, but it hasn't been used in the example.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants