-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: Optimized parts of the code in the gatt_server_service_table example. (IDFGH-11491) #12618
Conversation
👋 Welcome TritiumXs, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
|
Thank you for your feedback. The reason for writing it this way is primarily to emphasize the independence of the contents of adv_data and scan_rsp_data, aiming to prevent any potential misunderstanding on the part of the users. |
Okay, but the explanation for "scan_rsp_data.p_service_data" isn't the same as for "adv_data." This is a minor detail, but if this issue can be corrected, I believe it can be improved. |
Yes, we will further improve this area in the future. Do you find any other parts of the documentation unclear? We would greatly appreciate your feedback. |
Oh, indeed, there are some suggestions. UUIDs are really hard to remember. I think we can define a macro, allowing users to initialize using this macro and then modify it according to their needs. Also, the explanation for "raw_adv_data" in this example isn't very clear and may not be very friendly for developers new to BLE. I hope it can be supplemented more comprehensively. |
Alright, I will explain the format of raw_scan_rsp_data in the document later to make it easier for beginners to understand. |
And I found that the macro for "appearance" has already been defined, but it hasn't been used in the example. |
I found some redundancy in certain parts of the code, so I made modifications by removing redundant segments. These changes do not affect the functionality of the code.