Maintenance: Updates deps, CI steps and cleaner logs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Ah, finally figured it out. It's that the |
|
I reverted the esy lockfile and dependency changes because newer deps caused a problem that I couldn't solve, but I kept all the process improvements in place. If these changes are merged and released, I believe it will pick up the newest cygwin stuff that will also solve #54 |
|
I've also tested a fresh git-pull and ran all the scripts and everything works in my Windows 10 VM |
ManasJayanth
approved these changes
Nov 20, 2020
ManasJayanth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #54, I'm trying to update things where possible. Would love your feedback @bryphe and @ManasJayanth!