Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mjml mails #1255
Feature/mjml mails #1255
Changes from 18 commits
2253743
422b987
dcbc908
60d4787
5dafc50
bba3b34
7c5b03f
56f0f61
8875ac5
ff01ab6
a2a0f55
bad47a7
756d47c
f8f63c3
2cec683
873d6ac
304d82a
71940db
f485313
112e7a3
affd4ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple remarque,
entity_type
aurait été mieux,entity
on s'attend à un modèle.Honnêtement ce n'est pas très grave, ça pourra se scout commiter au besoin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je pense que l'ensemble des target blank ne seront pas fonctionnels, faudra tester en sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compliqué de tester les templates d'email en sandbox tant que j'ai pas migré le code hors de mailjet, donc je me note de tester ça plus tard quitte à supprimer les blank plus tard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est un mailer ça se fait en un one liner:
Faut le faire avant de merger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah bah oui -_- depuis la console... ugh mon cerveau est en vacances avec ce déménagement