Support new GTFS validation rule

See [UnusableTrip](etalab/transport-validator#211).
etalab · Jan 15, 2025 · fa4281a · fa4281a
1 parent 8b462be
commit fa4281a
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 1 deletion.
diff --git a/apps/transport/lib/transport_web/templates/resource/_gtfs_unusable_trip.html.heex b/apps/transport/lib/transport_web/templates/resource/_gtfs_unusable_trip.html.heex
@@ -0,0 +1,16 @@
+<p>
+  <%= dgettext("validations-explanations", "UnusableTrip") %>
+</p>
+<table class="table">
+  <tr>
+    <th><%= dgettext("validations-explanations", "Object type") %></th>
+    <th><%= dgettext("validations-explanations", "Object ID") %></th>
+  </tr>
+
+  <%= for issue <- @issues do %>
+    <tr>
+      <td><%= issue["object_type"] %></td>
+      <td><%= issue["object_id"] %></td>
+    </tr>
+  <% end %>
+</table>
diff --git a/apps/transport/lib/transport_web/views/resource_view.ex b/apps/transport/lib/transport_web/views/resource_view.ex
@@ -40,7 +40,8 @@ defmodule TransportWeb.ResourceView do
           "MissingId" => "_missing_id_issue.html",
           "MissingName" => "_missing_name_issue.html",
           "SubFolder" => "_subfolder_issue.html",
-          "NegativeStopDuration" => "_negative_stop_duration_issue.html"
+          "NegativeStopDuration" => "_negative_stop_duration_issue.html",
+          "UnusableTrip" => "_unusable_trip.html"
         },
         Transport.Validators.GTFSTransport.issue_type(issues.entries),
         "_generic_issue.html"

diff --git a/apps/transport/priv/gettext/en/LC_MESSAGES/validations-explanations.po b/apps/transport/priv/gettext/en/LC_MESSAGES/validations-explanations.po
@@ -146,3 +146,7 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "Details for debugging purposes"
 msgstr ""
+
+#, elixir-autogen, elixir-format
+msgid "UnusableTrip"
+msgstr "Trip with too many stops."
diff --git a/apps/transport/priv/gettext/fr/LC_MESSAGES/validations-explanations.po b/apps/transport/priv/gettext/fr/LC_MESSAGES/validations-explanations.po
@@ -146,3 +146,7 @@ msgstr "Emplacement inconnu"
 #, elixir-autogen, elixir-format
 msgid "Details for debugging purposes"
 msgstr "Détails à fin de débogage"
+
+#, elixir-autogen, elixir-format
+msgid "UnusableTrip"
+msgstr "Trip avec trop peu d’arrêts."
diff --git a/apps/transport/priv/gettext/validations-explanations.pot b/apps/transport/priv/gettext/validations-explanations.pot
@@ -145,3 +145,7 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "Details for debugging purposes"
 msgstr ""
+
+#, elixir-autogen, elixir-format
+msgid "UnusableTrip"
+msgstr ""