Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amélioration de la stabilité d'un test #4400

Merged

Conversation

AntoineAugusti
Copy link
Member

Fixes #4398

Il me semblait que le code précédent était suffisant pour avoir un tri déterministe mais on a eu au moins une occurence qui prouve le contrainte. Une création des 2 contacts lors de la même milliseconde ?!?

En triant par ID on devrait avoir quelque chose de plus stable, respectant l'ordre d'exécution :

  • création du contact dans la phase de setup du test
  • exécution du job, qui crée un second contact

@AntoineAugusti AntoineAugusti requested a review from a team as a code owner December 19, 2024 14:11
@AntoineAugusti AntoineAugusti added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 54c5928 Dec 20, 2024
4 checks passed
@AntoineAugusti AntoineAugusti deleted the import_gbfs_feed_contact_point_job_test_stability branch December 20, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test instable : import_gbfs_feed_contact_point_job_test.exs
2 participants