Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getLatestWALSnap into etcdutl/common.go #19173

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 11, 2025

This PR is extracted from #19168

cc @fuweid @serathius @ivanvc @jmhbnz @siyuanfoundation

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (9db8dcb) to head (8374966).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
etcdutl/etcdutl/common.go 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/etcdutl/migrate_command.go 0.00% <ø> (-9.79%) ⬇️
etcdutl/etcdutl/common.go 46.15% <66.66%> (+46.15%) ⬆️

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19173      +/-   ##
==========================================
- Coverage   68.87%   68.77%   -0.10%     
==========================================
  Files         420      420              
  Lines       35649    35654       +5     
==========================================
- Hits        24554    24522      -32     
- Misses       9674     9706      +32     
- Partials     1421     1426       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db8dcb...8374966. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit efff689 into etcd-io:main Jan 13, 2025
36 checks passed
@ahrtr ahrtr deleted the migrate_20250111 branch January 13, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants