Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat ClusterVersionSet as 3.5 version #19263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 23, 2025

Link to #19168

@ahrtr
Copy link
Member Author

ahrtr commented Jan 23, 2025

The test failures are expected. I will fix them later.

@serathius PTAL

@ahrtr
Copy link
Member Author

ahrtr commented Jan 23, 2025

cc @fuweid @siyuanfoundation

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (32cfd45) to head (aef91b8).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/wal/version.go 51.53% <100.00%> (ø)

... and 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19263      +/-   ##
==========================================
- Coverage   68.83%   68.79%   -0.05%     
==========================================
  Files         420      420              
  Lines       35678    35681       +3     
==========================================
- Hits        24560    24546      -14     
- Misses       9688     9713      +25     
+ Partials     1430     1422       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cfd45...aef91b8. Read the comment docs.

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Jan 24, 2025

This would probably not impact 3.6->3.5. But for 3.7->3.6 downgrade with offline migration, if there is an entry of ClusterVersionSet to be applied after the downgrade, would that mean the cluster version be set to 3.7 when the old ClusterVersionSet entry is applied?

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants