-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat ClusterVersionSet
as 3.5 version
#19263
base: main
Are you sure you want to change the base?
Conversation
The test failures are expected. I will fix them later. @serathius PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 27 files with indirect coverage changes @@ Coverage Diff @@
## main #19263 +/- ##
==========================================
- Coverage 68.83% 68.79% -0.05%
==========================================
Files 420 420
Lines 35678 35681 +3
==========================================
- Hits 24560 24546 -14
- Misses 9688 9713 +25
+ Partials 1430 1422 -8 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
8ac3f51
to
aef91b8
Compare
This would probably not impact 3.6->3.5. But for 3.7->3.6 downgrade with offline migration, if there is an entry of |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Link to #19168