Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to use bootstrap-defrag-threshold-megabytes flag #19267

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

gangli113
Copy link
Contributor

Migrate flag bootstrap-defrag-threshold-megabytes described in: #19141

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

Signed-off-by: Gang Li <gangligit@gmail.com>
@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (2ee7e34) to head (267020e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/bootstrap.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/config.go 79.59% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 76.49% <100.00%> (ø)
server/etcdmain/config.go 72.83% <100.00%> (+0.33%) ⬆️
server/etcdserver/bootstrap.go 63.59% <0.00%> (ø)

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19267      +/-   ##
==========================================
+ Coverage   68.77%   68.80%   +0.02%     
==========================================
  Files         420      420              
  Lines       35677    35680       +3     
==========================================
+ Hits        24538    24550      +12     
+ Misses       9714     9701      -13     
- Partials     1425     1429       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee7e34...267020e. Read the comment docs.

@siyuanfoundation
Copy link
Contributor

/ok-to-test

@gangli113
Copy link
Contributor Author

/cc @siyuanfoundation @serathius @ahrtr

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Jan 24, 2025

/test pull-etcd-e2e-amd64

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gangli113, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8731c31 into etcd-io:main Jan 25, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants