Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethapi: Add tests for SetCodeTx type to check Call functionality #30947

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ethapi: Add tests for SetCodeTx type to check Call functionality #30947

wants to merge 6 commits into from

Conversation

DarkLord017
Copy link

resolves #30920

I added tests similar that were pushed for eth_estimate gas what more tests can i add

@DarkLord017 DarkLord017 reopened this Dec 21, 2024
@s1na
Copy link
Contributor

s1na commented Jan 3, 2025

Right, as far as I can tell these cases test that a delegated account is still able to transfer value and call contracts as before. Fair.

Tho what I had in mind was testing the new functionality a bit. One of them being: doing a call where AuthorizationsList is non-empty and it tries to delegate an account. Another interesting one is using a 3rd account to call a delegated account.

@DarkLord017
Copy link
Author

Okay will surely add that !

@DarkLord017 DarkLord017 marked this pull request as ready for review January 6, 2025 12:15
@DarkLord017
Copy link
Author

@s1na @MariusVanDerWijden u can review it now

@fjl
Copy link
Contributor

fjl commented Jan 6, 2025

I would prefer if we added these tests over at https://github.com/lightclient/rpctestgen/blob/3d29578a9ceb231c0e212cd194cfd1dd7ecaeb42/testgen/generators.go#L524 instead

@DarkLord017
Copy link
Author

I would prefer if we added these tests over at https://github.com/lightclient/rpctestgen/blob/3d29578a9ceb231c0e212cd194cfd1dd7ecaeb42/testgen/generators.go#L524 instead

Should I go ahead and start making the changes there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setCode transaction type tests for eth_call and estimateGas
4 participants
@DarkLord017 @s1na @fjl @MariusVanDerWijden