-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for partial account helper functions #3745
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this AI generated? If so can we please establish the convention (within the whole team) to always clearly mark/label this as such?
If so, we should clearly exchange on some best practices on how to review such code and what expectation we put on it.
If not: my apologies. 😂
Sure, we can block this for now. I used AI to generate the boilerplate and cases, then reviewed, corrected, and filled in missing pieces of the tests to get it to compile 🙂. |
This change adds unit tests testing a variety of cases for the partial account helper functions:
createPartialAccount
createPartialAccountFromRLP
serializeWithPartialInfo