When creating an OiRa tool from a template, reset the UIDs to avoid c…

[ale-rt]

…omplaints from the catalog

[ale-rt]

The form URL is something like: https://example.com/sectors/eu/private-security-eu/++add++euphorie.surveygroup
To trigger the behavior you have to change the "How would you like to start" to the second or third option.

Without this patch you will see in the logs:

A different document with value '...' already exists in the index

[mauritsvanrees]

I tried and it works. But we can simplify by notifying the actual event. This works for me:

Suggested change

	# We use a fake event to reuse the subscriber from plone.uuid that
	# resets the UIDs on copy
	fake_copy_event = ObjectCopiedEvent(None, None)
	addAttributeUUID(copy, fake_copy_event)
	for id, item in copy.ZopeFind(copy, search_sub=1):
	addAttributeUUID(item, fake_copy_event)
	# This is handled by a subscriber in plone.uuid that resets the UIDs on copy.
	notify(ObjectCopiedEvent(copy, template))

[ale-rt]

I am a bit shy firing up the event because that can trigger unwanted subscribers

[mauritsvanrees]

I can imagine. But I am a bit shy about not firing the event, because then we miss wanted subscribers. I dug a bit and found a few that could be useful:

In CMFCore:

    elif IObjectCopiedEvent.providedBy(event):
        if hasattr(aq_base(ob), 'workflow_history'):
            del ob.workflow_history

In plone.app.linkintegrity:

    <subscriber
        for="plone.app.relationfield.interfaces.IDexterityHasRelations
             zope.lifecycleevent.interfaces.IObjectCopiedEvent"
        handler=".handlers.modifiedContent" />

In plone.app.multilingual:

@adapter(ITranslatable, IObjectCreatedEvent)
def addAttributeTG(obj, event):

    if (
        not IObjectCopiedEvent.providedBy(event)
        and getattr(aq_base(obj), ATTRIBUTE_NAME, None)
    ):
        return  # defensive: keep existing TG on non-copy create

Probably no big deal, but still my suggestion stands.

Anyway, this PR is an improvement already because it creates new UIDs, so I approve.