Add view that lists all links in a tool #781
Conversation
| attributes_checked = [ | ||
| "description", | ||
| "introduction", | ||
| "solution_direction", | ||
| "legal_reference", | ||
| "action", | ||
| "action_plan", | ||
| "prevention_plan", | ||
| "requirements", | ||
| ] |
There was a problem hiding this comment.
Are you sure these are all the fields in all relevant content types?
You could dynamically get all text fields and iterate over them. See how collective.searchandreplace does it. Ignore the Archetypes-related code. ;-)
| url_regex = re.compile( | ||
| r"https?://[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b" | ||
| r"(?:[-a-zA-Z0-9()@:%_+.~#?&/=]*)" | ||
| ) |
There was a problem hiding this comment.
This is probably fine. Alternative idea: look for contents of href/src, so ="http...", with at the dots anything except a double quote or a space. Something like this:
>>> re.compile(r'="(https?://[^ "]*)"').match('="https://some.url"').groups()
('https://some.url',)
| if hasattr(obj, "objectValues"): | ||
| for child in obj.objectValues(): |
There was a problem hiding this comment.
Theoretically objectValues can contain non-contentish items, for example an object for local workflow policies. If I want only content I prefer contentValues:
| if hasattr(obj, "objectValues"): | |
| for child in obj.objectValues(): | |
| if hasattr(obj, "contentValues"): | |
| for child in obj.contentValues(): |
| <dt tal:define=" | ||
| obj python:item['object']; | ||
| "> | ||
| <a href="${obj/absolute_url}">${obj/title}</a> |
There was a problem hiding this comment.
As you suggest in the issue, I would say it is better to link to the edit form directly:
| <a href="${obj/absolute_url}">${obj/title}</a> | |
| <a href="${obj/absolute_url}/edit">${obj/title}</a> |
Ref https://github.com/syslabcom/scrum/issues/2757