fix: aria attributes on stories tag search and advanced search term dropdowns #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployment: https://pr-2433.portal-js.dev.eanadev.org/ |
|
LeoniePeters
added
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements with the role
searchboxthat control the expansion and collapse of other elements should be wrapped in an element with rolecombobox.comboboxelements require a child with rolelistboxwhich require children with roleoption.For reference on the different aria roles, see: https://www.w3.org/TR/wai-aria-1.1/#combobox
This PR refactors the StoriesTagsDropdown and SearchQueryBuilderRuleTermInput to the required markup. That is also in line with what is already correctly implemented for the SearchForm.
To do:
listboxinto agridwhich might be more appropriate for the StoriesTagsDropdown