Added LCD, buttons and menu #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kwushot
commented
Aug 15, 2018
kwushot
commented
- Renamed and moved Clock to 7Segment
- Optimized clock refresh
- Add menu with LCD and button support
kwushot
commented
Aug 15, 2018
| @@ -0,0 +1,199 @@ | |||
| int segA = 1; | |||
There was a problem hiding this comment.
Ignore this file. I just renamed it from Clock. And it needs to be in a folder as the file enforced by the IDE.
evanlwj
reviewed
Aug 15, 2018
|
|
||
| bool buttonPressed(int button) { | ||
| bool pressed = false; | ||
| while (digitalRead(button) == LOW) { |
There was a problem hiding this comment.
Better without while loop to avoid blocking main thread from loop
evanlwj
reviewed
Aug 15, 2018
| return; | ||
| } | ||
|
|
||
| long now = millis() / 1000; |
There was a problem hiding this comment.
good to have a separated function like displayTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.