Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixbug] Add avatar to assignee on task creation (& task input dropdown UIs light/dark mode) #3531

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

CREDO23
Copy link
Contributor

@CREDO23 CREDO23 commented Jan 21, 2025

Description

Fix #3477
Fix #3474

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Current screenshots

Screenshot 2025-01-21 at 17 46 26 Screenshot 2025-01-21 at 17 46 59 Screenshot 2025-01-21 at 17 48 09 Screenshot 2025-01-21 at 17 48 30 Screenshot 2025-01-21 at 17 49 09 Screenshot 2025-01-21 at 17 49 26

Summary by CodeRabbit

Release Notes

  • UI Improvements

    • Enhanced project selection dropdown with improved visual feedback
    • Updated project icon to dynamically inherit parent text color
    • Refined task input assignee selection with more intuitive icons
    • Improved task status dropdown rendering and styling
  • Design Updates

    • Added CircleIcon to various components for better visual indication
    • Adjusted spacing and color styling across multiple UI elements
  • Code Refinements

    • Streamlined component prop handling
    • Improved conditional class application for more flexible styling

@CREDO23 CREDO23 self-assigned this Jan 21, 2025
@CREDO23 CREDO23 linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces several UI improvements across multiple components related to task management. The changes primarily focus on enhancing the visual representation and styling of project and assignee selection dropdowns. Key modifications include updating import statements, adjusting icon usage, refining component styling, and improving the flexibility of dropdown components. The changes aim to provide better visual feedback and more consistent user interface elements across the task creation and management workflow.

Changes

File Change Summary
apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx - Updated imports, replacing PlusIcon with CircleIcon
- Modified ProjectDropDown styling
- Adjusted spacing and icon display
apps/web/components/ui/svgs/project-icon.tsx - Changed SVG path fill attribute to currentColor for more flexible styling
apps/web/lib/features/task/task-input.tsx - Added UserGroupIcon import
- Updated AssigneesSelect component structure
- Improved assignee selection visual feedback
apps/web/lib/features/task/task-status.tsx - Reformatted component props
- Refined dropdown rendering logic
- Improved styling and conditional rendering

Assessment against linked issues

Objective Addressed Explanation
Add Avatar to Assignee on Task Creation [#3477] No avatar implementation added to assignee dropdown

Possibly related PRs

Suggested labels

feature, Improvement

Suggested reviewers

  • evereq
  • Cedric921

Poem

🐰 In the realm of code, where dropdowns dance,
Icons twirl with a stylish glance,
Paths now inherit their parent's hue,
Flexibility blooms, both old and new,
A rabbit's code-craft, precise and bright! 🎨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f40a8bf and 71e2b75.

📒 Files selected for processing (4)
  • apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx (3 hunks)
  • apps/web/components/ui/svgs/project-icon.tsx (1 hunks)
  • apps/web/lib/features/task/task-input.tsx (8 hunks)
  • apps/web/lib/features/task/task-status.tsx (7 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/web/components/ui/svgs/project-icon.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: deploy
🔇 Additional comments (10)
apps/web/components/pages/task/details-section/blocks/task-secondary-info.tsx (3)

24-24: LGTM! Import changes are well-organized.

The imports have been properly organized and the new CircleIcon is appropriately imported for the UI enhancements.

Also applies to: 29-31


377-383: LGTM! Enhanced visual feedback for project selection.

Good improvements:

  • Added CircleIcon as a visual indicator when no project is selected
  • Proper text alignment and spacing
  • Improved dark mode compatibility with proper font weight and colors

Line range hint 418-422: LGTM! Improved project list item styling.

Good improvements to the list items:

  • Better alignment and spacing between icon and text
  • Consistent height and padding
  • Proper dark mode text color
apps/web/lib/features/task/task-input.tsx (4)

29-31: LGTM! Import changes are well-organized.

The imports have been properly organized to support the assignee selection UI enhancements.

Also applies to: 52-52


573-573: LGTM! Improved dark mode styling for task labels.

Good improvement to task labels styling with proper dark mode support.


736-736: LGTM! Enhanced AssigneesSelect component.

Excellent improvements:

  • Added className prop for better component customization
  • Enhanced visual feedback with appropriate icons for selected/unselected states
  • Proper dark mode support with consistent styling

Also applies to: 757-780


789-796: LGTM! Improved dropdown styling.

Good improvements to the dropdown:

  • Better dark mode support with proper background and border colors
  • Enhanced active state styling for better visual feedback

Also applies to: 814-817

apps/web/lib/features/task/task-status.tsx (3)

829-840: LGTM! Improved type definitions.

Good improvements to the TaskStatus interface:

  • Better organized type definitions
  • Added new props for version and epic status support
  • Clear and descriptive prop names

992-993: LGTM! Enhanced TaskStatus styling.

Good improvements:

  • Better dark mode text colors
  • Consistent font sizes and weights
  • Proper text overflow handling with ellipsis

Also applies to: 999-1000


1239-1246: LGTM! Improved MultipleStatusDropdown styling.

Good improvements to the dropdown:

  • Better dark mode support with proper background and border colors
  • Enhanced text colors for selected/unselected states
  • Consistent styling with other components

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CREDO23 CREDO23 changed the title 3477 add avatar to assignee on task creation [Fixbug] Add avatar to assignee on task creation (& task input dropdown UIs light/dark mode) Jan 21, 2025
@CREDO23 CREDO23 requested review from Cedric921 and evereq January 21, 2025 16:16
@evereq evereq merged commit e0f2730 into develop Jan 21, 2025
13 checks passed
@evereq evereq deleted the 3477-add-avatar-to-assignee-on-task-creation branch January 21, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Avatar to Assignee on Task Creation UI Fixes - Task Creation Dropdown
2 participants